Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the farcaster-related hooks work with the new API #1518

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

No description provided.

@BrickheadJohnny BrickheadJohnny added the bug Something isn't working label Oct 8, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Oct 8, 2024
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:43am

@@ -1,23 +1,21 @@
import { useFarcasterAPI } from "@/hooks/useFarcasterAPI"
import { NEYNAR_BASE_URL } from "@/hooks/useFarcasterAPI/constants"
import type { NeynarAPIClient } from "@neynar/nodejs-sdk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the neynar sdk to include types. To prevent this next time, we could maybe use this. Although the update didn't seem like a small one.

@dominik-stumpf
Copy link
Contributor

dominik-stumpf commented Oct 8, 2024

Thank you for taking the time! Haven't tested, but the code looks good.

@BrickheadJohnny BrickheadJohnny merged commit 5fa402d into main Oct 8, 2024
6 checks passed
@BrickheadJohnny BrickheadJohnny deleted the use-farcaster-api-hook branch October 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants