Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move highlighted role to the top #1516

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

This is a temporary solution. Once we migrate the guild page to Tailwind CSS & Radix UI, we should try to render all roles at once (and optionally use content-visibility: auto for the role cards). If that solution works properly, we should remove this logic and the fake lazy loading too.

@BrickheadJohnny BrickheadJohnny added the feature New feature or request label Oct 3, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Oct 3, 2024
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:33pm

@BrickheadJohnny BrickheadJohnny merged commit 58dfc85 into main Oct 3, 2024
6 checks passed
@BrickheadJohnny BrickheadJohnny deleted the move-highlighted-role-to-the-top branch October 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant