Add text case changing functionality (Fixes #2390) #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor, addressing issue gsantner#2390. Users can now toggle case, switch case, capitalize words, and capitalize sentences directly from the Edit menu.
gsantner
reviewed
Sep 28, 2024
app/src/main/res/values/strings.xml
Outdated
| @@ -477,4 +477,9 @@ work. If not, see <https://creativecommons.org/publicdomain/zero/1.0/>. | |||
| <string name="wont_save_min_length">Files with fewer than %d characters not saved automatically in order to prevent data loss.</string> | |||
| <string name="advanced_filtering_help"><![CDATA[<small><a href="https://www.github.com/gsantner/markor/discussions/1940">Advanced filtering syntax</a></small>]]></string> | |||
| <string name="filter">Filter</string> | |||
| <string name="text_case">Text Case</string> | |||
| <string name="toggle_case">Toggle Case</string> | |||
There was a problem hiding this comment.
Thanks,
Suggestion, put a example at each like
AbC -> aBc
Abc -> ABC
There was a problem hiding this comment.
Hello, in which file should I add the examples? Should I add them into TextCasingUtils.java, DocumentEditAndViewFragment.java, or HighlightingEditor.java?
There was a problem hiding this comment.
Oh I see, thank you. I added an example to the display text of each text case now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to the Edit menu to include ability to change case. Fixes issue #2390 "Change text case".
This pull request introduces the following changes:
These changes allow users to perform the following text case operations from the Edit menu:
The new functionality respects the user's text selection, applying changes only to the selected text if a selection is active, or to the entire document if no text is selected. Please review and let me know if any changes or improvements are needed.