-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for the action buttons, closes #2386 #2388
Changes from all commits
f553c86
6953ff1
53c53b4
6c22b14
1e47ec9
0cc1963
1a1881d
5e73e84
0514cb2
e508ec9
2dd723d
47b400f
4f64f31
02bc11f
4f5862e
e2b1821
912735f
ef964ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,11 @@ public class TodoTxtBasicSyntaxHighlighter extends SyntaxHighlighterBase { | |
private final static int COLOR_CONTEXT = 0xff88b04b; | ||
|
||
private final static int COLOR_PRIORITY_A = 0xffEF2929; | ||
private final static int COLOR_PRIORITY_B = 0xffF57900; | ||
private final static int COLOR_PRIORITY_C = 0xff73D216; | ||
private final static int COLOR_PRIORITY_D = 0xff0099CC; | ||
private final static int COLOR_PRIORITY_E = 0xffEDD400; | ||
private final static int COLOR_PRIORITY_F = 0xff888A85; | ||
private final static int COLOR_PRIORITY_B = 0xffd16900; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you change those colors? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The B and C colors were disproportionately bright compared to the red color of A. The A priority, being most important, should be at least as much noticeable as the other ones. I used the perceived brightness formula to match the colors: Before: After: |
||
private final static int COLOR_PRIORITY_C = 0xff59a112; | ||
private final static int COLOR_PRIORITY_D = 0xff0091c2; | ||
private final static int COLOR_PRIORITY_E = 0xffa952cb; | ||
private final static int COLOR_PRIORITY_F = 0xff878986; | ||
|
||
private final static int COLOR_DONE_DARK = 0x999d9d9d; | ||
private final static int COLOR_DONE_LIGHT = 0x993d3d3d; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe the behaviour you are trying to achieve here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, when adding a new task below another, the task's priority would usually be the same.
The goal is to set/unset the priority to be the same as the top one.
This is what felt right to me for multi line:
That also means, that any priorities can be removed with at most two presses.
Might also add a check for the bottom line as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long pressing the priority button copies the priority from the first task to all the others?
Does this really need a long press? Currently one can select all the tasks and assign them a priority pretty easily.
You can select multiple tasks by simply creating a selection covering multiple tasks in the editor or by using the search dialog.
So search -> select all -> priority action -> select priority to assign to all selected tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "top" I mean the previous line from selection. Priority is copied to the selected lines.
The exact behavior is not set in stone, it's what I came up with.
In my experience, it feels much easier and responsive in daily use, as it makes creating another task with priority a little bit faster than the other methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.
So the current workflow is:
select -> priority action -> choose
And the new workflow for this use case is
select -> long press priority action
We're replacing 2 short presses with one long press.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well put