Add history scroll restoration for scroll views #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is painful and not user-friendly to scroll the view from the origin to the previous position with your fingers every time. Here is the 3 improved scroll views, you can make a comparison with a previous version. 2024-07-25-auto-restore-position.mp4 |
guanglinn
changed the title
gsantner
approved these changes
Jul 27, 2024
elyahw
pushed a commit
to writing-tools/marelias-notepad
that referenced
this pull request
Sep 26, 2024
* feat(font size dialog): add auto scroll for selection list * feat(special key dialog): add auto restore scroll for key list * feat(text actions bar): add auto restore scroll position * refactor: remove unnecessary font size in range 1 to 4 * refactor: minor improvements to padding of Markdown in view mode * refactor: minor improvements to padding of editor in edit mode (cherry picked from commit 80e813e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for auto scroll/history scroll restoration for scroll views. These features can improve the user experience.
In this PR:
FontSizeDialogcan auto scroll to the selection of current font size;
SpecialKeyDialogcan auto save and restore previous scroll position;
TextActionsBarcan keep scroll position even being reloaded;
minor improvements.