Jump to correct heading via id, other tweaks, bugfixes #2307

harshad1 · 2024-05-25T22:17:02Z

In this PR:

We have an improved jump to heading in view mode using line numbers as IDs @guanglinn please review
We move the 'format link' checkbox in the share activity to the top bar (takes even less space and is easy to see and use)
The todo txt filter now treats non-keyword strings as literal (case-insensitive) matches
Rework and unify markdown link highlighting and parsing
Fixed v2.12.2 New file Template name corresponds to wrong content #2312
Fixed unable to change Todo or quick note folder #2313 - Hiding new folder icon in these dialogs
If the typed in file name in the newfile dialog already exists, the dialog text colour will be red
Fix how file formats are detected
Save and restore file manager scroll state so that positions are maintained as one navigates
Dialogs now have rounded corners

harshad1 · 2024-05-25T22:17:37Z

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownTextConverter.java

@@ -440,4 +446,58 @@ private String replaceTokens(final String markup, final Map<String, List<String>

        return markupReplaced;
    }
+
+    private static class LineNumberIdProvider implements AttributeProvider {


So much boilerplate for a small extension

What this does is sets the id of every heading node to line-. This lets us jump to any heading super easily if we just know its line number.

harshad1 · 2024-05-26T01:55:36Z

@guanglinn this PR improves how we jump to headings. We attach the heading line number as the html node id and then jump directly to it.

I think we can even use this method to sync edit and view positions in the future .

It's wip because I want to reorganize the code a little.

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java

app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownActionButtons.java

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownSyntaxHighlighter.java

harshad1 · 2024-06-02T21:21:41Z

~~Marked WIP as I found a bug when you open a file from the share into dialog~~

All known issues fixed now

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java

app/src/main/java/net/gsantner/markor/frontend/NewFileDialog.java

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java

gsantner · 2024-07-16T17:58:17Z

Tried the blinking as read the question - yes much better then the last few tries. That looks OK to me.

gsantner · 2024-07-16T18:01:30Z

Of the rounded dialogs, personally humbly said I like it better non rounded. But I'm not strong opposed.

gsantner · 2024-07-16T18:04:50Z

app/src/main/java/net/gsantner/markor/format/FormatRegistry.java

-            new Format(FormatRegistry.FORMAT_EMBEDBINARY, R.string.embed_binary, ".jpg", CONVERTER_EMBEDBINARY),
            new Format(FormatRegistry.FORMAT_PLAIN, R.string.plaintext, ".txt", CONVERTER_PLAINTEXT),
+            new Format(FormatRegistry.FORMAT_EMBEDBINARY, R.string.embed_binary, ".jpg", CONVERTER_EMBEDBINARY),


Is there a specific reason to move this one down again? I placed it abvoe plaintext so i.e. .m3u gets taken to that converter for music/video playlist support, all in view mode.

gsantner · 2024-07-16T18:09:13Z

Thank you other then those two I didn't find anything else. Thanks much for your contribution!

harshad1 · 2024-07-17T02:57:47Z

Tried the blinking as read the question - yes much better then the last few tries. That looks OK to me.

That's good. I can work on adding things to make it even more clear if needed.

Is there a specific reason to move this one down again? I placed it abvoe plaintext so i.e. .m3u gets taken to that converter for music/video playlist support, all in view mode.

No. This was an error which I missed. Thanks for catching this and fixing it.

harshad1 · 2024-07-17T03:00:35Z

Tried the blinking as read the question - yes much better then the last few tries. That looks OK to me.

That's good. I can work on adding things to make it even more clear if needed.

Is there a specific reason to move this one down again? I placed it abvoe plaintext so i.e. .m3u gets taken to that converter for music/video playlist support, all in view mode.

No. This was an error which I missed. Thanks for catching this and fixing it.

harshad1 · 2024-07-17T03:02:23Z

Of the rounded dialogs, personally humbly said I like it better non rounded. But I'm not strong opposed.

Google's design guides all want rounded now. If you feel that it isn't nice after some more testing we can reduce the radius to a smaller number. Feedback on this is always appreciated.

@harshad1

by @harshad1, fixes gsantner#2312 gsantner#2313) * Jump to correct heading via id * No need to track lines * As link checkbox to top bar * Simplify heading, checkbox to title, task filter literal * Unified and cleaned up link formatting * new file dialog fixes, no folder in select qn / todo * launch in new activity * Improvement to launching activities * Fixed + improved isFileOutOfThisFormat * Switching from blink to ripple * Logic to save and restore file browser position * Can scroll action bar on repeat items * Handle unknown formats better * Handle virtual folders better * Rounded dialogs, fixes for launching files * Improved show and flash * Improved keyboard showing * Improved how we test for compatible files * Cleaner way to do dialog radius * Better showing of folders * Rounded corners for all dialogs, cleaner structure * Better text file detection * Cleaner style system * Matching colour * Match system bars with UI colors * Rounded widget corners, hide text actions bar --------- Co-authored-by: Gregor Santner <[email protected]> (cherry picked from commit 92744b3)

Jump to correct heading via id

db2581e

harshad1 commented May 25, 2024

View reviewed changes

No need to track lines

0e1c90e

harshad1 added 3 commits May 26, 2024 12:07

Clanups

dc23d15

As link checkbox to top bar

bc2d84c

Simplify heading, checkbox to title, task filter literal

ed067ff

harshad1 changed the title ~~WIP: Jump to correct heading via id~~ WIP: Jump to correct heading via id, other changes May 26, 2024

harshad1 commented May 26, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java Show resolved Hide resolved

harshad1 commented May 26, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java Show resolved Hide resolved

Cleanups

7f35212

harshad1 commented May 26, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java Show resolved Hide resolved

Unified and cleaned up link formatting

58df0fa

harshad1 commented May 30, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java Show resolved Hide resolved

harshad1 commented May 30, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownActionButtons.java Show resolved Hide resolved

harshad1 commented May 30, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownSyntaxHighlighter.java Outdated Show resolved Hide resolved

harshad1 commented May 30, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownSyntaxHighlighter.java Show resolved Hide resolved

new file dialog fixes, no folder in select qn / todo

4900732

harshad1 changed the title ~~WIP: Jump to correct heading via id, other changes~~ Jump to correct heading via id, other tweaks, bugfixes Jun 1, 2024

This was referenced Jun 1, 2024

ShareInto: Pipe ("|") in text association breaks GitHub Markdown for links #2308

Closed

Zim format detection does not work in 2.12.1 and 2.12.2 #2316

Closed

harshad1 changed the title ~~Jump to correct heading via id, other tweaks, bugfixes~~ WIP: Jump to correct heading via id, other tweaks, bugfixes Jun 2, 2024

harshad1 added 3 commits June 2, 2024 18:31

launch in new activity

5c7b194

Improvement to launching activities

0188154

Added comment on preview states

e947739

harshad1 changed the title ~~WIP: Jump to correct heading via id, other tweaks, bugfixes~~ Jump to correct heading via id, other tweaks, bugfixes Jun 3, 2024

harshad1 commented Jun 3, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java Show resolved Hide resolved

harshad1 commented Jun 3, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java Show resolved Hide resolved

harshad1 commented Jun 3, 2024

View reviewed changes

app/src/main/java/net/gsantner/markor/frontend/NewFileDialog.java Show resolved Hide resolved

harshad1 commented Jul 6, 2024

View reviewed changes

app/src/main/java/net/gsantner/opoc/frontend/GsSearchOrCustomTextDialog.java Show resolved Hide resolved

bruvellu mentioned this pull request Jul 6, 2024

Crash when creating new note with zim-wiki-empty.txt template #2340

Closed

4 tasks

harshad1 and others added 5 commits July 6, 2024 23:32

Cleaner style system

cebf97f

Matching colour

3a7f816

Match system bars with UI colors

bce6cb2

Rounded widget corners, hide text actions bar

167d5e9

Reformat code

686ab20

gsantner assigned harshad1 Jul 16, 2024

gsantner added bug enhancement labels Jul 16, 2024

gsantner reviewed Jul 16, 2024

View reviewed changes

make plaintext last check in hierachy again

066330d

gsantner merged commit 92744b3 into gsantner:master Jul 16, 2024
1 check passed

gsantner added this to the Markor v2.13 milestone Jul 16, 2024

guanglinn mentioned this pull request Jul 25, 2024

v2.12.3 View-mode Table of contents links broken #2364

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jump to correct heading via id, other tweaks, bugfixes #2307

Jump to correct heading via id, other tweaks, bugfixes #2307

harshad1 commented May 25, 2024 •

edited

Loading

harshad1 May 25, 2024

harshad1 Jun 3, 2024

harshad1 commented May 26, 2024

harshad1 commented Jun 2, 2024 •

edited

Loading

gsantner commented Jul 16, 2024

gsantner commented Jul 16, 2024 •

edited

Loading

gsantner Jul 16, 2024

gsantner commented Jul 16, 2024

harshad1 commented Jul 17, 2024

harshad1 commented Jul 17, 2024

harshad1 commented Jul 17, 2024

Jump to correct heading via id, other tweaks, bugfixes #2307

Jump to correct heading via id, other tweaks, bugfixes #2307

Conversation

harshad1 commented May 25, 2024 • edited Loading

harshad1 May 25, 2024

Choose a reason for hiding this comment

harshad1 Jun 3, 2024

Choose a reason for hiding this comment

harshad1 commented May 26, 2024

harshad1 commented Jun 2, 2024 • edited Loading

gsantner commented Jul 16, 2024

gsantner commented Jul 16, 2024 • edited Loading

gsantner Jul 16, 2024

Choose a reason for hiding this comment

gsantner commented Jul 16, 2024

harshad1 commented Jul 17, 2024

harshad1 commented Jul 17, 2024

harshad1 commented Jul 17, 2024

harshad1 commented May 25, 2024 •

edited

Loading

harshad1 commented Jun 2, 2024 •

edited

Loading

gsantner commented Jul 16, 2024 •

edited

Loading