New folder in copy/move dialog, closes #2093 #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works. But I am having some problems with the search bar.
These exist in the current dialog too These problems also exist in the current move dialog but should be fixed before I am ready to call this done. |
|
New dialog |
|
Issue with keyboard
|
harshad1
commented
Aug 26, 2023
| @@ -40,10 +40,11 @@ public static GsFileBrowserOptions.Options prepareFsViewerOpts(Context context, | |||
| opts.doSelectFolder = doSelectFolder; | |||
| opts.doSelectFile = !doSelectFolder; | |||
|
|
|||
| opts.searchHint = R.string.search_documents; | |||
There was a problem hiding this comment.
Not the best default in many cases
harshad1
commented
Aug 26, 2023
app/src/main/java/net/gsantner/markor/frontend/textview/TextViewUtils.java
Show resolved
Hide resolved
harshad1
commented
Aug 26, 2023
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java
Show resolved
Hide resolved
harshad1
commented
Aug 26, 2023
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java
Show resolved
Hide resolved
harshad1
commented
Aug 26, 2023
harshad1
changed the title
|
This seems to be working well. Marking it ready. |
|
@harshad1 But I still merge this now, want to make sure everything gets a bit together now 😄 . Moving the UI around is rather something quick done any time. |
gsantner
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I address #2093
I have added a new file dialog to the move / copy / create dialogs
I have also reworked the UI to use floating buttons