Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2a: clean up usage of certs #11583

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

rmehta19
Copy link
Contributor

@rmehta19 rmehta19 commented Oct 1, 2024

Address cert comments on:
#11540
#11113 (comment)

FakeWriter initializePrivateKey() throws InvalidKeySpecException, NoSuchAlgorithmException {
FakeWriter initializePrivateKey() throws InvalidKeySpecException, NoSuchAlgorithmException,
IOException, FileNotFoundException, UnsupportedEncodingException {
FileInputStream keyInputStream =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use try-with-resources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 2, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 2, 2024
@larry-safran larry-safran merged commit b8a0ba4 into grpc:master Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants