-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add fix for xdstp replacement for encoded authorities (#10571)
In ac35ab6 the logic in xDS Name resolver was changed to support encoded authorities. This seems to cause an issue for xdstp replacements which would percent encode the authority for the replacement causing double encoding. For example: URI = xds:///path/to/service Authority = path%2Fto%2Fservice xdstp resource = xdstp:///envoy.config.listener.v3.Listener/path%252Fto%252Fservice Here the authority is encoded due to slashes and during replacement we percent encode it again causing %2F to change to %252F. To avoid this issue, use the encoded authority only for the getServiceAuthority() API and for all other use cases retain the unencoded authority.
- Loading branch information
Showing
2 changed files
with
32 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters