Skip to content

Commit

Permalink
README.md: Revert reference to protobuf 3.23.4 (#10430)
Browse files Browse the repository at this point in the history
The README describes the released version of gRPC. But the most recent
release doesn't use protobuf 3.23.4. Telling people to use protoc 3.23.4
is asking for breakages because they will be running with protobuf-java
3.22.3, which is a downgrade.

The bump to 3.23.4 was incorrectly done in #10359.
  • Loading branch information
ejona86 authored Aug 3, 2023
1 parent 1638ce3 commit 4049f89
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ For protobuf-based codegen integrated with the Maven build system, you can use
<artifactId>protobuf-maven-plugin</artifactId>
<version>0.6.1</version>
<configuration>
<protocArtifact>com.google.protobuf:protoc:3.23.4:exe:${os.detected.classifier}</protocArtifact>
<protocArtifact>com.google.protobuf:protoc:3.22.3:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.57.1:exe:${os.detected.classifier}</pluginArtifact>
</configuration>
Expand Down Expand Up @@ -157,7 +157,7 @@ plugins {
protobuf {
protoc {
artifact = "com.google.protobuf:protoc:3.23.4"
artifact = "com.google.protobuf:protoc:3.22.3"
}
plugins {
grpc {
Expand Down Expand Up @@ -190,7 +190,7 @@ plugins {
protobuf {
protoc {
artifact = "com.google.protobuf:protoc:3.23.4"
artifact = "com.google.protobuf:protoc:3.22.3"
}
plugins {
grpc {
Expand Down

0 comments on commit 4049f89

Please sign in to comment.