request to add israel #829
Conversation
|
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
|
I accept the Contributor License Agreement |
|
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
|
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
| @@ -395,6 +395,11 @@ and always knows where you are to not miss where to get off the bus. | |||
| <string name="np_desc_hungary">Budapest, Miskolc</string> | |||
| <string name="np_desc_hungary_networks" translatable="false">BKK, MKV</string> | |||
|
|
|||
| <string name="np_name_israel">Israel</string> | |||
| <string name="np_desc_israel">Jerusalem</string> | |||
There was a problem hiding this comment.
Out of curiosity, does this provider only serve in Jerusalem?
| @@ -757,6 +757,18 @@ private val networks = arrayOf( | |||
| factory = { DubProvider() } | |||
| ) | |||
| ) | |||
| ),Country( | |||
There was a problem hiding this comment.
nit: formatting
| ),Country( | |
| ), | |
| Country( |
|
Again, thanks for the contribution. I'm closing this as there is no activity. Feel free to reopen if you're still interested in working on it. |
please see issue #769 ,
as per Hungary example , I added icon and description .