-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request to add israel #829
Conversation
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
I accept the Contributor License Agreement |
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @nomq1 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and thanks for the contribution. If you can include some screenshots in the PR comment/description, it'd be awesome.
@@ -395,6 +395,11 @@ and always knows where you are to not miss where to get off the bus. | |||
<string name="np_desc_hungary">Budapest, Miskolc</string> | |||
<string name="np_desc_hungary_networks" translatable="false">BKK, MKV</string> | |||
|
|||
<string name="np_name_israel">Israel</string> | |||
<string name="np_desc_israel">Jerusalem</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, does this provider only serve in Jerusalem?
@@ -757,6 +757,18 @@ private val networks = arrayOf( | |||
factory = { DubProvider() } | |||
) | |||
) | |||
),Country( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: formatting
),Country( | |
), | |
Country( |
Again, thanks for the contribution. I'm closing this as there is no activity. Feel free to reopen if you're still interested in working on it. |
please see issue #769 ,
as per Hungary example , I added icon and description .