"@OverRide" should be used on overriding and implementing methods

groldan · Dec 5, 2023 · b8f215a · b8f215a
1 parent 68810ec
commit b8f215a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/catalog/plugin/src/main/java/org/geoserver/catalog/plugin/CatalogPlugin.java b/src/catalog/plugin/src/main/java/org/geoserver/catalog/plugin/CatalogPlugin.java
@@ -199,14 +199,17 @@ public CatalogFacade getRawFacade() {
      * <p>This is not part of the public api, it is used for testing purposes where we have to
      * bootstrap catalog contents.
      */
+    @Override
     public void setExtendedValidation(boolean extendedValidation) {
         validationSupport.setExtendedValidation(extendedValidation);
     }
 
+    @Override
     public boolean isExtendedValidation() {
         return validationSupport.isExtendedValidation();
     }
 
+    @Override
     public void setFacade(CatalogFacade facade) {
         this.rawFacade = facade;
         ExtendedCatalogFacade efacade;
@@ -1317,7 +1320,7 @@ public void dispose() {
         facade.dispose();
     }
 
-    // @Override TODO: add to the interface
+    @Override
     public void fireBeforeAdded(CatalogInfo object) {
         CatalogBeforeAddEventImpl event = new CatalogBeforeAddEventImpl();
         event.setSource(object);

diff --git a/.../main/java/org/geoserver/catalog/plugin/forwarding/ForwardingRepositoryCatalogFacade.java b/.../main/java/org/geoserver/catalog/plugin/forwarding/ForwardingRepositoryCatalogFacade.java
@@ -111,6 +111,7 @@ public MapRepository getMapRepository() {
         return facade().getMapRepository();
     }
 
+    @Override
     protected RepositoryCatalogFacade facade() {
         return (RepositoryCatalogFacade) facade;
     }