Accessibility, bug, performance, and misc fixes #103
Conversation
|
✔️ Deploy Preview for lab-website-template ready! 🔨 Explore the source changes: 43e4408 🔍 Inspect the deploy log: https://app.netlify.com/sites/lab-website-template/deploys/618c43f062f1a9000769878a 😎 Browse the preview: https://deploy-preview-103--lab-website-template.netlify.app |
|
✔️ Deploy Preview for lab-website-template ready! 🔨 Explore the source changes: affaf21 🔍 Inspect the deploy log: https://app.netlify.com/sites/lab-website-template/deploys/619289b54f83ec0007a6a50f 😎 Browse the preview: https://deploy-preview-103--lab-website-template.netlify.app |
vincerubinetti
changed the title
|
@cgreene I know you're ultra busy but could you give this a blessing just based on the bullet points above. Atm I don't know anyone really qualified to review the code, either with respect to Jekyll or the established codebase of the template. I'll give it a detailed look over myself before merge as well. |
- take site-wide google search on 404 page and make it into reusable component (see #2) - remove gallery from readme (since we'll be want to update it somewhat regularly) and move to wiki - set `img` alt attributes as appropriate - refactor sections to be only one html element - load font awesome async for performance - add spots for extra details in footer, and add ad for template - move some basic items in head to meta - turn logo-text config option into simple boolean - fix small blog post excerpt bug - defer load all scripts - move from popper.js to tippy.js for tooltips - add accessible label to search box - make tags component accept list or comma-separated values more robustly - fix two col component bug where it can't accept markdown - add html doctype and lang to prevent warnings and various issues - remove bash scripts that no-one should probably be using, and are documented in the wiki anyway - various css tweaks - add aria labels to anchors - fix anchor move-to-parent bug - on team page, replace dead link to non-existent join page with just some job positing filler details (see greenelab#86 for discussion) - test each page with lighthouse (in chrome dev tools), mobile and desktop
closes #95
closes #98
closes #101
closes #102
imgalt attributes as appropriate