Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-page drop downs to navigation bar in header #86

Open
vincerubinetti opened this issue Jul 27, 2021 Discussed in #85 · 2 comments
Open

Add sub-page drop downs to navigation bar in header #86

vincerubinetti opened this issue Jul 27, 2021 Discussed in #85 · 2 comments
Labels
enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

Discussed in #85

Originally posted by BioMeCIS July 27, 2021
I'd like to add dropdown menus on the top Nav Bar, similar to https://gladstone.org/ website. Is there a way to do so with the current SCSS components?

@vincerubinetti vincerubinetti changed the title How to add a drop down on the Navigation Bar? Add drop downs to nav bar Jul 27, 2021
@vincerubinetti vincerubinetti added the enhancement New feature or request label Jul 27, 2021
@vincerubinetti vincerubinetti added the wontfix This will not be worked on label Nov 8, 2021
@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Nov 8, 2021

Unfortunately, for now, I've decided to not implement this feature because 1) only one person has requested it so far, 2) it would add significant code complexity for me and configuration complexity for all other users, and 3) I generally believe that if you need drop down menus, there are better ways to organize your content.

Regarding the last point, consider this. Do 20 different pages need to be accessible at any possible time from the header? Or are some of those pages a little less important, and maybe it'd be fine if they're accessed by first going to a more general top level page in the header.

For example, if you had separate "People", "Sponsors", and "Photos" pages, they could all go under a single top level "Team" page which then has big links to the sub pages.

If more people request this feature (please signify your interest with a 👍 ) I can reopen this issue.

@vincerubinetti vincerubinetti changed the title Add drop downs to nav bar Add sub-page drop downs to navigation bar in header Nov 8, 2021
vincerubinetti added a commit that referenced this issue Nov 15, 2021
- take site-wide google search on 404 page and make it into reusable component (see #2)
- remove gallery from readme (since we'll be want to update it somewhat regularly) and move to wiki
- set `img` alt attributes as appropriate
- refactor sections to be only one html element
- load font awesome async for performance
- add spots for extra details in footer, and add ad for template
- move some basic items in head to meta
- turn logo-text config option into simple boolean
- fix small blog post excerpt bug
- defer load all scripts
- move from popper.js to tippy.js for tooltips
- add accessible label to search box
- make tags component accept list or comma-separated values more robustly
- fix two col component bug where it can't accept markdown
- add html doctype and lang to prevent warnings and various issues
- remove bash scripts that no-one should probably be using, and are documented in the wiki anyway
- various css tweaks
- add aria labels to anchors
- fix anchor move-to-parent bug
- on team page, replace dead link to non-existent join page with just some job positing filler details (see #86 for discussion)
- test each page with lighthouse (in chrome dev tools), mobile and desktop
hyphaltip pushed a commit to stajichlab/stajichlab.github.io that referenced this issue Jul 21, 2022
- take site-wide google search on 404 page and make it into reusable component (see #2)
- remove gallery from readme (since we'll be want to update it somewhat regularly) and move to wiki
- set `img` alt attributes as appropriate
- refactor sections to be only one html element
- load font awesome async for performance
- add spots for extra details in footer, and add ad for template
- move some basic items in head to meta
- turn logo-text config option into simple boolean
- fix small blog post excerpt bug
- defer load all scripts
- move from popper.js to tippy.js for tooltips
- add accessible label to search box
- make tags component accept list or comma-separated values more robustly
- fix two col component bug where it can't accept markdown
- add html doctype and lang to prevent warnings and various issues
- remove bash scripts that no-one should probably be using, and are documented in the wiki anyway
- various css tweaks
- add aria labels to anchors
- fix anchor move-to-parent bug
- on team page, replace dead link to non-existent join page with just some job positing filler details (see greenelab#86 for discussion)
- test each page with lighthouse (in chrome dev tools), mobile and desktop
@vincerubinetti vincerubinetti removed the wontfix This will not be worked on label Feb 19, 2023
@vincerubinetti
Copy link
Collaborator Author

I will reconsider this. I think if it's an option, more people will use it (though I still think they maybe shouldn't).

I'll actually try to implement it and see how much complexity it adds. Reference: https://moderncss.dev/css-only-accessible-dropdown-navigation-menu/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant