-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign seal #83
Sign seal #83
Conversation
## What Revert #83, which added connection options in a hardcoded way. <!-- Describe what changes are being made, e.g. which feature/bug is being developed/fixed in this PR? How did you verify the changes in this PR? --> ## Why With greenbone/openvas-scanner#1355 this options can be added when calling wmic or wmi via the library, and currently defaults to [sign]. This hardcoded options collide with the default or provided one. For testing: ``` wmic -d 7 -U domain/user%pass //192.168.0.1[sign,seal] "SELECT name FROM Win32_ComputerSystem" ``` or ``` `` <!-- Describe why are these changes necessary? --> ## References <!-- Add identifier for issue tickets, links to other PRs, etc. --> ## Checklist <!-- Remove this section if not applicable to your changes --> - [ ] Tests
Hello @ramijebara, Thanks a lot for your contribution. Unfortunately, I had to revert this PR, since it generate conflict with the existing way of adding options. |
What
Added sign, seal to the bindstr variable, to samba/lib/com/dcom/main.c. Based on my experience, communication with newer versions of windows is much more reliable. queries that fail with the un-patched code work with this change.
Why
I was trying to communicate with fully patched Windows Server 2016+ machines and the default code was failing communication. After much research and testing of community suggestions I found that this change makes the communication much more reliable.
It has been tested for around 6 months.
References
This change was initially proposed in PR#81
jira issue reference: SC-953 // this line was added by ArnoStiefvater