feat(Notifications): Added archived state, NotificationsPopupWrapper component and enhanced the stories for notifications
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Notifications' stories
…feat-added-archived-state-and-enhanced-the-stories-for-notifications
…ies and README.md
|
Preview is ready. |
Ruminat
changed the title
NotificationsPopupWrapper component and enhanced the stories for notificationsNotificationsPopupWrapper component and enhanced the stories for notifications
| const style = wrapperMaxHeight === undefined ? {} : {maxHeight: `${wrapperMaxHeight}px`}; | ||
|
|
||
| if (isRemoved) { | ||
| return <></>; |
…feat-added-archived-state-and-enhanced-the-stories-for-notifications
korvin89
requested changes
Aug 4, 2023
| const [wrapperMaxHeight, setWrapperMaxHeight] = React.useState<number | undefined>(undefined); | ||
| const [isRemoved, setIsRemoved] = React.useState(false); | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
it is a little bit weird that notification manages it's visibility state by itself
There was a problem hiding this comment.
It's because we need to animate the removing effect (archive)
I thought it would be more convenient if we manage it in the NotificationWrapper component
|
@korvin89 ping |
…feat-added-archived-state-and-enhanced-the-stories-for-notifications
korvin89
approved these changes
Aug 9, 2023
Ruminat
deleted the
feat-added-archived-state-and-enhanced-the-stories-for-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features:
InfiniteScrollfunctionality to Notifications.NotificationsPopupWrappercomponent with some styles so it would be easier to use Notifications inside a popup.Fixed problems:
cursor: pointerto active notifications (with non-emptyonClick).[UXRFC-114]