-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OnboardingMenu): add re-export and docs #166
Conversation
Preview is ready. |
src/components/index.ts
Outdated
@@ -18,3 +18,4 @@ export * from './SharePopover'; | |||
export * from './StoreBadge'; | |||
export * from './Stories'; | |||
export * from './StoriesGroup'; | |||
export * from './OnboardingMenu'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort list please for easy navigation
onCollapseClick?: (event: React.MouseEvent) => void; | ||
}; | ||
|
||
type OnboardingMenu.ItemProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type OnboardingMenu.ItemProps = { | |
type OnboardingMenuItemProps = { |
loading?: boolean; | ||
}; | ||
|
||
type OnboardingMenu.ItemImage = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type OnboardingMenu.ItemImage = { | |
type OnboardingMenuItemImage = { |
alt: string; | ||
}; | ||
|
||
type OnboardingMenu.ItemText = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type OnboardingMenu.ItemText = { | |
type OnboardingMenuItemText = { |
src: string; | ||
alt: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong props
CODEOWNERS
Outdated
@@ -9,3 +9,4 @@ | |||
/src/components/StoreBadge @NikitaCG | |||
/src/components/Stories @darkgenius | |||
/src/components/AdaptiveTabs @artemipanchuk | |||
/src/components/OnboardingMenu @nikita-jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort the list)
No description provided.