Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify props.py #1511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RJPercival
Copy link

@RJPercival RJPercival commented Jul 4, 2023

It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.

This could be simplified further, e.g. by skipping any attributes that start with an underscore, but that would be a behavioural change, whereas this PR is a pure refactoring.

It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.
@erikwrede
Copy link
Member

Thanks for the PR @RJPercival 🙂
Could you please run the pre-commit hooks before commiting, so that the linter runs? Feel free to tag me after the PR is updated, will merge then. 😊

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d77d0b0) 96.01% compared to head (6d609db) 96.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   96.01%   96.00%   -0.01%     
==========================================
  Files          51       51              
  Lines        1755     1753       -2     
==========================================
- Hits         1685     1683       -2     
  Misses         70       70              
Impacted Files Coverage Δ
graphene/utils/props.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants