Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom model for mobile devices (plus separate settings panel) #316

Merged
merged 28 commits into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
87c4f6d
initial version
karussell Mar 13, 2023
a6e4321
custom model is kept even when switching back and forth between deskt…
karussell Mar 15, 2023
61ccbd6
fix bug when mobile view is changed to compact view and no new route …
karussell Mar 16, 2023
b697750
move CustomModelBox into SettingsBox but outside of settingsTable
karussell Mar 16, 2023
7b7839a
minor -> warn
karussell Mar 16, 2023
c476d81
minor css fix
karussell Mar 17, 2023
63ea078
make settings css better fit the rest
karussell Mar 17, 2023
aee208b
1. URL with custom_model should trigger a routing request with it; 2.…
karussell Mar 18, 2023
7ef455e
Merge branch 'master' into gear_as_setting_button
karussell Mar 18, 2023
96108d7
tricky to fix error 'Cannot use import statement outside a module' in…
karussell Mar 19, 2023
885a2c6
Merge branch 'master' into gear_as_setting_button
karussell Mar 21, 2023
d1e707a
remove CustomModel from QueryStore state
karussell Mar 21, 2023
9ed5ed1
Merge branch 'master' into gear_as_setting_button
karussell Mar 21, 2023
f57ac3e
formatting
karussell Mar 21, 2023
35f091c
Merge branch 'master' into gear_as_setting_button
karussell Mar 21, 2023
34b091d
revert change with SettingsContext to use ShowDistanceInMilesContext
karussell Mar 22, 2023
1657925
format and clean up imports
easbar Mar 22, 2023
78b25ca
show error message if invalid custom model (not possible at Settings …
karussell Mar 22, 2023
6625911
not many benefits to use validateJson as e.g. encoded values not yet …
karussell Mar 22, 2023
fe88161
revert commit 96108d7e07af7811bdf908d32b8fc4f6804c3e89
karussell Mar 22, 2023
ddc4015
Merge branch 'master' into gear_as_setting_button
karussell Mar 22, 2023
e3ca24d
remove TODO NOW
karussell Mar 22, 2023
cc658e3
Use string to represent custom model state (#320)
easbar Mar 23, 2023
d1f245b
no shadow, use text instead
karussell Mar 23, 2023
bcc0d55
i18n: update
karussell Mar 23, 2023
b6284f8
Merge branch 'master' into gear_as_setting_button
karussell Mar 23, 2023
d9df268
separate custom model box and settings box and use gear as indicator …
karussell Mar 23, 2023
f04c3be
format
karussell Mar 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 34 additions & 11 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import Menu from '@/sidebar/menu.svg'
import Cross from '@/sidebar/times-solid.svg'
import PlainButton from '@/PlainButton'
import useAreasLayer from '@/layers/UseAreasLayer'
import { Settings } from '@/stores/SettingsStore'

export const POPUP_CONTAINER_ID = 'popup-container'
export const SIDEBAR_CONTENT_ID = 'sidebar-content'
Expand Down Expand Up @@ -99,7 +100,7 @@ export default function App() {
// our different map layers
useBackgroundLayer(map, mapOptions.selectedStyle)
useMapBorderLayer(map, info.bbox)
useAreasLayer(map, query.customModelEnabled && query.customModelValid ? query.customModel?.areas! : null)
useAreasLayer(map, getCustomModelAreas(query))
useRoutingGraphLayer(map, mapOptions.routingGraphEnabled)
useUrbanDensityLayer(map, mapOptions.urbanDensityEnabled)
usePathsLayer(map, route.routingResult.paths, route.selectedPath)
Expand All @@ -119,6 +120,7 @@ export default function App() {
mapOptions={mapOptions}
error={error}
encodedValues={info.encoded_values}
settings={settings}
/>
) : (
<LargeScreenLayout
Expand All @@ -128,6 +130,7 @@ export default function App() {
mapOptions={mapOptions}
error={error}
encodedValues={info.encoded_values}
settings={settings}
/>
)}
</div>
Expand All @@ -142,10 +145,12 @@ interface LayoutProps {
mapOptions: MapOptionsStoreState
error: ErrorStoreState
encodedValues: object[]
settings: Settings
}

function LargeScreenLayout({ query, route, map, error, mapOptions, encodedValues }: LayoutProps) {
const [showSidebar, setShowSidebar] = useState(true)
const [showCustomModelBox, setShowCustomModelBox] = useState(false)
return (
<>
{showSidebar ? (
Expand All @@ -157,15 +162,18 @@ function LargeScreenLayout({ query, route, map, error, mapOptions, encodedValues
<RoutingProfiles
routingProfiles={query.profiles}
selectedProfile={query.routingProfile}
customModelAllowed={true}
customModelEnabled={query.customModelEnabled}
/>
<CustomModelBox
enabled={query.customModelEnabled}
encodedValues={encodedValues}
initialCustomModelStr={query.initialCustomModelStr}
queryOngoing={query.currentRequest.subRequests[0]?.state === RequestState.SENT}
showCustomModelBox={showCustomModelBox}
toggleCustomModelBox={() => setShowCustomModelBox(!showCustomModelBox)}
customModelBoxEnabled={query.customModelEnabled}
/>
{showCustomModelBox && (
<CustomModelBox
customModelEnabled={query.customModelEnabled}
encodedValues={encodedValues}
customModelStr={query.customModelStr}
queryOngoing={query.currentRequest.subRequests[0]?.state === RequestState.SENT}
/>
)}
<Search points={query.queryPoints} />
<div>{!error.isDismissed && <ErrorMessage error={error} />}</div>
<RoutingResults
Expand Down Expand Up @@ -201,11 +209,17 @@ function LargeScreenLayout({ query, route, map, error, mapOptions, encodedValues
)
}

function SmallScreenLayout({ query, route, map, error, mapOptions }: LayoutProps) {
function SmallScreenLayout({ query, route, map, error, mapOptions, encodedValues, settings }: LayoutProps) {
return (
<>
<div className={styles.smallScreenSidebar}>
<MobileSidebar query={query} route={route} error={error} />
<MobileSidebar
query={query}
route={route}
error={error}
encodedValues={encodedValues}
settings={settings}
/>
</div>
<div className={styles.smallScreenMap}>
<MapComponent map={map} />
Expand All @@ -231,3 +245,12 @@ function SmallScreenLayout({ query, route, map, error, mapOptions }: LayoutProps
</>
)
}

function getCustomModelAreas(queryStoreState: QueryStoreState): object | null {
if (!queryStoreState.customModelEnabled) return null
try {
return JSON.parse(queryStoreState.customModelStr)['areas']
} catch {
return null
}
}
4 changes: 2 additions & 2 deletions src/NavBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export default class NavBar {

result.searchParams.append('profile', queryStoreState.routingProfile.name)
result.searchParams.append('layer', mapState.selectedStyle.name)
if (queryStoreState.customModelEnabled && queryStoreState.customModel && queryStoreState.customModelValid)
result.searchParams.append('custom_model', JSON.stringify(queryStoreState.customModel))
if (queryStoreState.customModelEnabled)
result.searchParams.append('custom_model', queryStoreState.customModelStr.replace(/\s+/g, ''))

return result
}
Expand Down
16 changes: 7 additions & 9 deletions src/actions/Actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class InvalidatePoint implements Action {
}
}

export class SetCustomModelBoxEnabled implements Action {
export class SetCustomModelEnabled implements Action {
readonly enabled: boolean

constructor(enabled: boolean) {
Expand All @@ -86,14 +86,12 @@ export class SetCustomModelBoxEnabled implements Action {
}

export class SetCustomModel implements Action {
readonly customModel: CustomModel | null
readonly valid: boolean
readonly issueRouteRequest

constructor(customModel: CustomModel | null, valid: boolean, issueRouteRequest = false) {
this.customModel = customModel
this.valid = valid
this.issueRouteRequest = issueRouteRequest
readonly customModelStr: string
readonly issueRoutingRequest: boolean

constructor(customModelStr: string, issueRoutingRequest: boolean) {
this.customModelStr = customModelStr
this.issueRoutingRequest = issueRoutingRequest
}
}

Expand Down
14 changes: 14 additions & 0 deletions src/sidebar/CustomModelBox.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@
height: 18rem;
}

.customModelOptionTable {
display: grid;
font-size: 14px;
grid-template-columns: 15% auto;
grid-template-rows: 1.3rem;
align-content: center;
align-items: center;
margin: 1.5rem 0.5rem 0.5rem 0;
}

.customModelOptionTable svg {
scale: 0.7;
}

#element::-webkit-scrollbar {
display: none;
}
Expand Down
Loading