Rename cache clearing test so that tests have distinct names #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests had the same name, "allows clearAll values in cache". The second test with this name was added in 13ae83d. Renamed that second test so that all tests have unique names.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! I noticed while debugging the intermittently failing test in #73 (comment) that there were two tests with that name ("allows clearAll values in cache"). The second test with this name was added in 13ae83d. Renamed that second test so that all tests have unique names. Since this test seemed to be testing the
WithClearCacheOnBatchconfig method more than theClearAllmethod, I based the name on that. Happy to update if you have any suggestions. Thanks!