-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ApiConstants type and DEFAULT_UPDATE_TYPES #453
Conversation
export the `DEFAULT_UPDATE_TYPES` constant and the `ApiConstants` type from the `src/convenience/constants.ts`
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 46.39% 46.38% -0.02%
==========================================
Files 19 19
Lines 5610 5612 +2
Branches 222 224 +2
==========================================
Hits 2603 2603
- Misses 3004 3006 +2
Partials 3 3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also perform https://t.me/grammyjs/146352
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not quite happy with the lack of docs. See https://doc.deno.land/https://raw.githubusercontent.com/grammyjs/grammY/b4a7d41f39fa4611726aad1f8a2fc229431428e5/src/convenience/constants.ts. If you deem fixing this out of scope for this PQ, then we can postpone it. What do you think?
That's weird.
I think it can be the same PQ |
@KnorpelSenf Remove the co-authors from the description before merging. |
Any ideas on how we could solve this? |
Perhaps by extracting the docs into an interface and adding a type annotation to the variable. Hopefully, it doesn't have to be exported. Perhaps we must export it but not from mod.ts. Perhaps we just have to export it. You'll need to try. |
Yep, exporting the interface works |
export the
DEFAULT_UPDATE_TYPES
constant and theApiConstants
type from the
src/convenience/constants.ts