Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disruptors: refuse to inject a fault on pods with hostNetwork set to true #257

Merged
merged 2 commits into from
Jul 20, 2023
Merged

disruptors: refuse to inject a fault on pods with hostNetwork set to true #257

merged 2 commits into from
Jul 20, 2023

Conversation

roobre
Copy link
Collaborator

@roobre roobre commented Jul 20, 2023 •
edited
Loading

Description

Fixes #216

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

pablochacin
pablochacin approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roobre
Copy link
Collaborator Author

roobre commented Jul 20, 2023 

go test -tags e2e ./e2e/disruptors/...
ok  	github.com/grafana/xk6-disruptor/e2e/disruptors	272.532s

@roobre roobre merged commit 9f56de7 into main Jul 20, 2023
6 checks passed
@roobre roobre deleted the fail-hostnetwork branch July 20, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablochacin pablochacin pablochacin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn about, or prevent users from disrupting pods with hostNetwork
2 participants
@roobre @pablochacin