Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trigger-argo-workflow): set up golang before argo setup #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(trigger-argo-workflow): set up golang before argo setup #430

wants to merge 1 commit into from

Conversation

SimKev2
Copy link

@SimKev2 SimKev2 commented Sep 27, 2024

Ran into an issue on arm self-hosted runners that go couldn't be called to calculate the os/arch when setting up argo. Setting up golang first should allow that code to function again.

@SimKev2 SimKev2 requested a review from a team as a code owner September 27, 2024 18:24
@SimKev2 SimKev2 changed the title Set up golang before argo setup fix(trigger-argo-workflow) : Set up golang before argo setup Sep 27, 2024
@SimKev2 SimKev2 changed the title fix(trigger-argo-workflow) : Set up golang before argo setup fix(trigger-argo-workflow): Set up golang before argo setup Sep 27, 2024
@SimKev2 SimKev2 changed the title fix(trigger-argo-workflow): Set up golang before argo setup fix(trigger-argo-workflow): set up golang before argo setup Sep 27, 2024
iainlane
iainlane requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for this. I just want to hold this for a little minute as we expect go to be in the default path and it seems like an issue with our self-hosted runners that it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimKev2 @iainlane