chore: make the update-contributors workflow run monthly #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
approved these changes
Oct 16, 2024
| @@ -24,7 +24,7 @@ jobs: | |||
| git config --local user.email '[email protected]' | |||
| if ! git diff --exit-code README.md; then | |||
| git add README.md | |||
| git commit -m 'docs: updates the list of contributors in README [skip ci]' | |||
There was a problem hiding this comment.
Another option would be to run it monthly but keep the skip ci flag to avoid having an image tied to this commit. The only necessary check would be to schedule it for Wednesday(?), to allow some buffer after our release day.
There was a problem hiding this comment.
I am unsure about bringing back the skip ci flag. If we have a slow week (not many PRs merged), we can get in the same situation again where we can't cut a release. If there are no PRs merged between that Wednesday and Monday, the weekly release will fail and if we decide to make the official release on the same Wednesday it can break too.
kolesnikovae
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3574 by scheduling the workflow to run on the first
daySunday of every month and removing the [skip ci] flag in the commit.We don't really need frequent updates imo and if we run it monthly we don't have to worry about it being wasteful.
There is a small chance of jobs getting cancelled if someone merges a PR right around when this runs (midnight UTC, on the first day of the month), I don't think this is a real problem but we could update the concurrency config if it becomes an issue.This probability is now reduced by having it run on the first Sunday of the month, at 00:00 UTC.