Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renaming merge commands to profile #3630

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

alsoba13
Copy link
Contributor

@alsoba13 alsoba13 commented Oct 15, 2024

Simple refactor here: just renaming profilecli query merge to profilecli query profile (same for profilecli admin blocks query merge), while keeping the old merge subcommand as a valid alias.

Doc updated accordingly

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! The updates look good.

Base automatically changed from alsoba13/cli-refactor-admin-block to main October 16, 2024 09:57
@alsoba13 alsoba13 marked this pull request as ready for review October 16, 2024 10:01
@alsoba13 alsoba13 requested review from a team as code owners October 16, 2024 10:01
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alsoba13! I personally like the new CLI much better

@alsoba13 alsoba13 enabled auto-merge (squash) October 17, 2024 10:42
@alsoba13 alsoba13 merged commit 919e28a into main Oct 17, 2024
18 checks passed
@alsoba13 alsoba13 deleted the alsoba13/profilecli-rename-merge-to-profile branch October 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants