refactor: unify query and query-blocks #3623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: profilecli query-blocks merge
alsoba13
commented
Oct 14, 2024
| @@ -65,11 +65,11 @@ func main() { | |||
| tsdbSeriesFiles := tsdbSeriesCmd.Arg("file", "tsdb file path").Required().ExistingFiles() | |||
|
|
|||
| queryCmd := app.Command("query", "Query profile store.") | |||
| queryMergeCmd := queryCmd.Command("merge", "Request merged profile.") | |||
| queryMergeOutput := queryMergeCmd.Flag("output", "How to output the result, examples: console, raw, pprof=./my.pprof").Default("console").String() | |||
There was a problem hiding this comment.
Output flag is used in both merge and go-pgo. We can safely move it to addQueryMergeParams which is also called by addQueryGoPGOParams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
query-blocksintoquery. Now, in the presence of--blockflag, the query will be performed directly on a local/remote block instead of using a pyroscope server.profilecli query mergein favor ofprofilecli query profile. Oldmergegets hidden from doc (although still runnable) and logs a deprecation notice.