Use default sample rate of 100 per second for CPU #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
commented
Jun 6, 2024
| @@ -82,7 +82,7 @@ type FlamebearerMetadataV1 struct { | |||
| Format string `json:"format"` | |||
| // Name of the spy / profiler used to generate the profile, if any. | |||
| SpyName string `json:"spyName"` | |||
| // Sample rate at which the profiler was operating. | |||
| // Sample rate at which the profiler was operating. Note: This unit is not related to the Units field and is measured in samples per second. | |||
| SampleRate uint32 `json:"sampleRate"` | |||
There was a problem hiding this comment.
I am not too sure if this is the right type and definition. I think it would be better if we would signal the sampleRate per SampleUnit. But for this we would need to change the field to be a float.
The default 100 Hz, would become 0.00001 per nanosecond. Any insights that you have on this @korniltsev
This fixes the default sample rate for profiling and clarfies the field value. Relates to grafana#3340.
simonswine
force-pushed
the
20240606_use-default-cpu-sample-rate
branch
from
dcf5123
to
81c66e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the default sample rate for profiling and clarfies the field value. Relates to #3340.