Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix CI #96

Merged
merged 1 commit into from
Jan 22, 2024
Merged

chore: fix CI #96

merged 1 commit into from
Jan 22, 2024

Conversation

kolesnikovae
Copy link
Contributor

  • Excludes example package from tests: main is declared twice, which is fine, but breaks CI – maybe we should put examples into a submodule
  • Replaces github.com/pyroscope-io/client/pyroscope with github.com/grafana/pyroscope-go

korniltsev
korniltsev approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotip is broken because of new go version
https://github.com/grafana/pyroscope-go/pull/95/files

@kolesnikovae
Copy link
Contributor Author

Yeah, just have seen the PR

@kolesnikovae kolesnikovae marked this pull request as ready for review January 22, 2024 05:15
@kolesnikovae kolesnikovae merged commit d7cd7b7 into main Jan 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @korniltsev