Skip to content

Commit

Permalink
fix(godeltaprof/compat): compilation on gotip (#132)
Browse files Browse the repository at this point in the history
fix #129
upgrade to golang.org/x/[email protected] when running tests on gotip
  • Loading branch information
korniltsev authored Oct 1, 2024
1 parent 46ebf82 commit f8bc5c6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
echo "GOPATH=$HOME/go" >> "$GITHUB_ENV"
echo "$HOME/go/bin" >> "$GITHUB_PATH"
echo "$HOME/sdk/gotip/bin" >> "$GITHUB_PATH"
make gotip/fix
- name: Build example application
run: go build example/main.go
- name: Run tests
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/gotip_cron_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
echo "GOPATH=$HOME/go" >> "$GITHUB_ENV"
echo "$HOME/go/bin" >> "$GITHUB_PATH"
echo "$HOME/sdk/gotip/bin" >> "$GITHUB_PATH"
make gotip/fix
- name: Build example application
run: go build example/main.go
- name: Run tests
Expand Down
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,10 @@ go/mod:
cd godeltaprof/ && GO111MODULE=on go mod tidy
cd x/k6/ && GO111MODULE=on go mod download
cd x/k6/ && GO111MODULE=on go mod tidy

# https://github.com/grafana/pyroscope-go/issues/129
.PHONY: gotip/fix
gotip/fix:
cd godeltaprof/compat/ && gotip get -d -v golang.org/x/[email protected]
git --no-pager diff
! git diff | grep toolchain

0 comments on commit f8bc5c6

Please sign in to comment.