Skip to content

Commit

Permalink
Merge pull request #91 from grafana/90-xk6-topic-on-oss-only
Browse files Browse the repository at this point in the history
xk6 topic not required for internal extensions
  • Loading branch information
szkiba authored Oct 11, 2024
2 parents 3648f0e + 5ec79b5 commit ff22729
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
12 changes: 7 additions & 5 deletions cmd/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,19 @@ func validateWithLinter(registry k6registry.Registry) error {
}

func hasTopic(ext k6registry.Extension) bool {
found := false

for _, topic := range ext.Repo.Topics {
if topic == "xk6" {
found = true
return true
}
}

break
for _, product := range ext.Products {
if product == k6registry.ProductOSS { // for oss, topic is required
return false
}
}

return found
return true // for non oss, topic isn't required
}

func lintExtension(ext k6registry.Extension) (bool, []string) {
Expand Down
9 changes: 9 additions & 0 deletions releases/v0.1.32.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
k6registry `v0.1.32` is here 🎉!

This is an internal maintenance release.

**xk6 topic not required for internal extensions**

The internal linter previously expected the `xk6` topic to be set on the extensions repository. In the case of internal (albeit public) extensions, it would not be a good idea to use the `xk6` topic, because that would cause them to appear in the GitHub topic search.

The internal linter now does not expect the xk6 topic to be set for extensions that do not have `oss` in their `products` property. That is, in the case of extensions that cannot be used in Grafana k6, the use of the `xk6` topic is not required.

0 comments on commit ff22729

Please sign in to comment.