[tempo-distributed] Adds global extraEnv support to deployed components #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrady
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
rbrady
changed the title
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
e0e60d6
to
32b098a
Compare
There was a problem hiding this comment.
Hey @rbrady could you please share the mimir reference for this change.
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
32b098a
to
8257470
Compare
Sheikh-Abubaker
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
LGTM! Thanks! for the Contribution @rbrady, keep them coming!
Most of the deployed components did not apply the global extraEnv in the deployment templates. This resulted in having to duplicate extraEnv vars in the values/overrides files. This change uses the pattern from mimir to create an env: for a deployment if the .Values.global.extraEnv or .Values.<component>.extraEnv exists. It also adds the global extraEnv section to the values.yaml file. Signed-off-by: Ryan Brady <[email protected]>
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
8257470
to
2126cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the deployed components did not apply the global extraEnv in the deployment templates. This resulted in having to duplicate extraEnv vars in the values/overrides files. This change uses the pattern from mimir to create an env: for a deployment if the .Values.global.extraEnv or .Values..extraEnv exists. It also adds the global extraEnv section to the values.yaml file.
Closes #3332