Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single quotes to avoid shell evaluation when copy-pasting commands #219

Merged
merged 2 commits into from
May 21, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented May 21, 2024

Otherwise Markdown backticks are evaluated and someone could feasibly craft a malicious title.

@jdbaldry jdbaldry requested a review from a team as a code owner May 21, 2024 10:25
@jdbaldry jdbaldry changed the title Use single quotes to avoid shell expansion when copy-pasting commands Use single quotes to avoid shell evaluation when copy-pasting commands May 21, 2024
Signed-off-by: Jack Baldry <[email protected]>
Copy link

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how am I going to command inject malicious code now?!?!?! NO fun.

@jdbaldry jdbaldry merged commit 6afa9f5 into main May 21, 2024
3 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-05-fix-quoting branch May 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants