Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "distributor" section support to mimir config file #247

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

HamzaKhait
Copy link
Contributor

Hello,

This small edit allows users to add distributor section to mimir config file.
The distributor section is mandatory for Mimir high-availability deduplication.
Here's an example :

... 

limits:
  accept_ha_samples: true


distributor:
  ha_tracker:
    enable_ha_tracker: true
    kvstore:
      store: etcd
      etcd:
        tls_enabled: false
        endpoints:
        - 10.103.0.174:2379
        - 10.103.0.71:2379

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024

CLA assistant check
All committers have signed the CLA.

@GVengelen
Copy link
Collaborator

Looks good to me

@HamzaKhait
Copy link
Contributor Author

HamzaKhait commented Jul 24, 2024

Hello @GVengelen and thanks for your feedback.
Do you have any idea why this job fails ? https://github.com/grafana/grafana-ansible-collection/actions/runs/10005925119/job/27691899573?pr=247. is it related to my pull request ?

@gjvengelen
Copy link

I think it has something to do with a python version mismatch.
I’m currently away for holiday can have a look early next week.

@HamzaKhait
Copy link
Contributor Author

Ok, thank you for your quick response.
Enjoy your holiday :-)

@ishanjainn
Copy link
Member

Yeah PR LGTM too but will wait for @GVengelen to see if the Mimir failure is someting to be fixed in this

@HamzaKhait
Copy link
Contributor Author

Hello guys,
@GVengelen any news about this issue ? 🙏

@gjvengelen
Copy link

Today is my first day after the holidays. Will have time tomorrow so will sort this out tomorrow.

@gerardvanengelen
Copy link

Issue is not related to this change. Working on it but this change can be merged.

@ishanjainn ishanjainn merged commit f274ee8 into grafana:main Oct 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants