-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alloy variables to use the grafana_alloy_
namespace so they are unique
#209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefix the variables with alloy_
rather than grafana_alloy_
to comply with the ansible-lint rule var-naming[no-role-prefix]
as the role name is alloy
and not grafana_alloy
Hey @Aethylred Yeah would prefer to use |
Switched to Apologies about the delay, with the Alloy setup being immature, we switched to using the standard Grafana setup. Will be skipping Grafana Agent & Flow and waiting for Alloy. |
BOth of the PRs seem to achive the same thing, @Aethylred Lemme know if the other PR loogs good to you aswell and we can use that or the other way around? |
Looking at #228 and it looks good, I'd consider it a duplicate, but whichever crosses the line first is fine by me |
…tion and doesnt upset SELinux and grafana#194
c035901
to
30eb8c1
Compare
Rebased on main. Not sure how to resolve the workflow errors. |
Any updates on this one? Looks like the only thing missing is approval for workflows to run |
Changes LGTM, Ill just test on local by tomorrow and merge release if all good |
Hello ! Do you have any updates on this MR ? When will it be merge ? I don't know the process here It looks like @ishanjainn is pending reviewer |
Looking at those failed checks and I'm unsure if the problem is my MR, should I rebase again? |
Dont think so it related to your changes, Chnages LGTM |
Hello @ishanjainn It reverts this:
The I added MR 276. Thanks in advance |
Commit 8dbd124 broke grafana#212, see comments: - grafana#212 (comment) - grafana#209 (comment)
This should address #206 and #194
This PR should make sure the Alloy variables are unique and won't clash with other variables (like
version
) used elsewhere in playbooks.It also moves the binary and working directory out of
/etc
where RHEL and SELinux get upset about.