Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trigger): add custom get metadata hook #342

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

sgabb
Copy link
Contributor

@sgabb sgabb commented Aug 30, 2024

The implementation aims to add a new trigger function enabling users to retrieve metadata in a complete custom way together with the possibility to use all the inputs of the original get_metadata function.

Details:

  • use custom trigger to override metadata retrieval
  • update README
  • update tests with new functions

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgabb Thanks for the awesome contribution! I'll remove the prints and merge it.

django_saml2_auth/tests/test_saml.py Outdated Show resolved Hide resolved
sgabb and others added 3 commits September 11, 2024 15:44
- use custom trigger to override metadata retrieval
- update README
- update tests with new functions
@sgabb
Copy link
Contributor Author

sgabb commented Sep 11, 2024

Great, sorry that I forgot the prints! Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants