-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Linux capabilities config for pyroscope.java #1788
docs: add Linux capabilities config for pyroscope.java #1788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating doc. Do we need to backport?
Yes, I added the corresponding labels. Thanks! |
@marcsanmi can we also add this somewhere to a couple other places:
Again even though we are duplicating this in a couple places we often have many paths through which people enter the docs and having this key information at least mentioned everywhere is important |
Do we need to duplicate the exact documentation with no changes? If so, we can consider sharing content between repositories. For example, store the source doc in the Alloy repo and then include that source doc in one or more other locations using an include statement. |
As discussed in grafana/pyroscope#3599 (comment), it doesn't make sense to add this documentation in pyroscope examples since this related to Alloy's chart configuration. |
f8ce01d
to
4c1606c
Compare
Co-authored-by: Clayton Cornell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor tweak - use of whitelist and it's good from my side :-)
Co-authored-by: Clayton Cornell <[email protected]>
Is this one ready to be merged as-is? |
Yes 👍 |
Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 7e8c153)
Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 7e8c153)
Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 7e8c153)
Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 7e8c153)
Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 7e8c153)
Co-authored-by: Clayton Cornell <[email protected]>
PR Description
Update
pyroscope.java
documentation to include information on configuring Linux capabilities when running in Kubernetes environments. This addition helps users properly set up Alloy with the necessary permissions for Java process profiling in environments where Linux capabilities are enforced.Which issue(s) this PR fixes
Closes #1616
Notes to the Reviewer
PR Checklist
CHANGELOG.md updatedTests updatedConfig converters updated