Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add retry timeout #26

Merged
merged 6 commits into from
Apr 24, 2024
Merged

feat: add retry timeout #26

merged 6 commits into from
Apr 24, 2024

Conversation

deryrahman
Copy link
Member

@deryrahman deryrahman commented Apr 18, 2024 •
edited
Loading

  • add retry_timeout_in_seconds configuration to configure custom timeout on retry
  • add timeout and ssl error as error worth to retry
  • add log_level in config
  • upgrade api_core and bigquery client google

arinda-arif
arinda-arif approved these changes Apr 23, 2024
View reviewed changes
Copy link

@arinda-arif arinda-arif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please do a final round of testing before merging, due to recent changes.
Thank you

@deryrahman deryrahman merged commit 2e20092 into main Apr 24, 2024
2 checks passed
arinda-arif pushed a commit that referenced this pull request Jul 8, 2024
@deryrahman @arinda-arif
feat: add retry timeout (#26)
33dd510 
* feat: add retry timeout

* feat: upgrade bigquery client version + add timeout as a predicate to retry

* feat: rename retry config env

* feat: include SSLError as error worth to retry

* feat: add log level config

* fix: assigned retry object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinda-arif arinda-arif arinda-arif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deryrahman @arinda-arif