Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #425

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Add files via upload #425

merged 6 commits into from
Oct 27, 2023

Conversation

danielatgoogle
Copy link
Contributor

Hello DevRel friends!

Description

Working with @gtondello, I'm uploading code samples for the Google Chat Advanced Service in Apps Script launch.

Fixes # (issue)

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Hello DevRel friends,

Working with @gtondello, I'm uploading code samples for the upcoming Google Chat Advanced Service in Apps Script launch.  These code samples pair with the following bugs and documentation changelists.
@snippet-bot
Copy link

snippet-bot bot commented Oct 26, 2023

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

advanced/chat.gs Outdated Show resolved Hide resolved
advanced/chat.gs Outdated Show resolved Hide resolved
advanced/chat.gs Show resolved Hide resolved
advanced/chat.gs Outdated Show resolved Hide resolved
advanced/chat.gs Outdated Show resolved Hide resolved
danielatgoogle and others added 2 commits October 27, 2023 10:36
Co-authored-by: Gustavo Tondello <[email protected]>
Fixing member >>> membership per Gustavo's feedback in #425 (comment).
advanced/chat.gs Outdated Show resolved Hide resolved
danielatgoogle and others added 2 commits October 27, 2023 10:59
Co-authored-by: Gustavo Tondello <[email protected]>
Fixing the following linter errors:

1.  On line 107, "Expected parentheses around arrow function argument".

2.  On lines, 108, 109, and 110, " Expected indentation of 10 spaces but found 8".
@danielatgoogle danielatgoogle enabled auto-merge (squash) October 27, 2023 18:28
@sqrrrl sqrrrl disabled auto-merge October 27, 2023 18:41
@sqrrrl sqrrrl merged commit 097b9c6 into main Oct 27, 2023
20 of 26 checks passed
@sqrrrl sqrrrl deleted the danielatgoogle-chat-advanced-service branch October 27, 2023 18:41
brentchang pushed a commit to brentchang/apps-script-samples that referenced this pull request Dec 3, 2023
* Add files via upload

Hello DevRel friends,

Working with @gtondello, I'm uploading code samples for the upcoming Google Chat Advanced Service in Apps Script launch.  These code samples pair with the following bugs and documentation changelists.

* Updating chat.gs with sqrrrl's feedback

* Update advanced/chat.gs

Co-authored-by: Gustavo Tondello <[email protected]>

* Fixing member >>> membership in chat.gs

Fixing member >>> membership per Gustavo's feedback in googleworkspace#425 (comment).

* Update advanced/chat.gs

Co-authored-by: Gustavo Tondello <[email protected]>

* Fixing linter errors in chat.gs

Fixing the following linter errors:

1.  On line 107, "Expected parentheses around arrow function argument".

2.  On lines, 108, 109, and 110, " Expected indentation of 10 spaces but found 8".

---------

Co-authored-by: Gustavo Tondello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants