Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix system test async test #1514

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: fix system test async test #1514

wants to merge 5 commits into from

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@cindy-peng cindy-peng added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 12, 2024
@cindy-peng cindy-peng requested review from a team as code owners June 12, 2024 23:43
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/nodejs-logging API. labels Jun 12, 2024
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jul 13, 2024
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/nodejs-logging API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cindy-peng