Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a view on the instance, not on the table #1476

Conversation

danieljbruce
Copy link
Contributor

@danieljbruce danieljbruce commented Sep 23, 2024

Summary:

This PR is being added to address a recent minor change suggested in the design document for Bigtable Authorized Views. To support future feature work, the views should be decoupled from tables and therefore created using a Bigtable instance object instead of a table object.

Background:

This PR is part of a series of PRs for introducing the Bigtable Authorized Views feature. So far this PR and this PR have been merged.

Changes

  1. Add the view method to Instance.
  2. Remove the view method from Table.
  3. Modify the authorized view constructor not to require the whole table

Next Steps

(Verbatim from the previous PR)

  1. Write some tests that use the new increment, createRules and filter methods now available on AuthorizedView. Make sure that these methods pass the proper parameters along and that they target an authorized view.
  2. Write a PR for supporting authorized views calls for all methods of the TabularApiSurface class.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 23, 2024
Copy link

conventional-commit-lint-gcf bot commented Sep 23, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Sep 23, 2024
@danieljbruce danieljbruce marked this pull request as ready for review September 23, 2024 21:07
@danieljbruce danieljbruce requested review from a team as code owners September 23, 2024 21:07
@danieljbruce danieljbruce merged commit d293abd into bigtable-authorized-views Sep 30, 2024
12 of 16 checks passed
@danieljbruce danieljbruce deleted the bigtable-authorized-views-create-view-change branch September 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants