Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix deadline exceeded error in readstream test #1336

Merged
merged 3 commits into from
Oct 2, 2023
Merged

test: Fix deadline exceeded error in readstream test #1336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f0cef9
Remove workaround
danieljbruce Sep 29, 2023
9a47034
Remove workaround for read stream test
danieljbruce Sep 29, 2023
01ab35b
Increase the test timeout
danieljbruce Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions test/readrows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,7 @@ describe('Bigtable/ReadRows', () => {
let receivedRowCount = 0;
let lastKeyReceived: number | undefined;

const readStream = table.createReadStream({
// workaround for https://github.com/grpc/grpc-node/issues/2446, remove when fixed
gaxOptions: {
timeout: 3000,
},
});
const readStream = table.createReadStream();
readStream.on('error', (err: GoogleError) => {
done(err);
});
Expand Down Expand Up @@ -225,7 +220,7 @@ describe('Bigtable/ReadRows', () => {
// TODO: enable after https://github.com/googleapis/nodejs-bigtable/issues/1286 is fixed
it('should be able to stop reading from the read stream when reading asynchronously', function (done) {
if (process.platform === 'win32') {
this.timeout(60000); // it runs much slower on Windows!
this.timeout(600000); // it runs much slower on Windows!
}

// 1000 rows must be enough to reproduce issues with losing the data and to create backpressure
Expand All @@ -242,12 +237,7 @@ describe('Bigtable/ReadRows', () => {
let lastKeyReceived: number | undefined;

// BigTable stream
const readStream = table.createReadStream({
// workaround for https://github.com/grpc/grpc-node/issues/2446, remove when fixed
gaxOptions: {
timeout: 3000,
},
});
const readStream = table.createReadStream();

// Transform stream
const transform = new Transform({
Expand Down
Loading