Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add retries to increase reliability of test #1319

Merged
merged 6 commits into from
Oct 23, 2023
Merged

test: Add retries to increase reliability of test #1319

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbcf0ad
Skip a flakey test
danieljbruce Aug 15, 2023
da9b5eb
Remove block of code for skipped test
danieljbruce Aug 15, 2023
8e3847e
Merge branch 'main' into skip-the-close-client-test
danieljbruce Aug 22, 2023
4122667
Add retry options
danieljbruce Aug 24, 2023
d049dba
Merge branch 'main' into skip-the-close-client-test
danieljbruce Oct 18, 2023
622db0f
Merge branch 'main' into skip-the-close-client-test
danieljbruce Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion system-test/read-rows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('Bigtable/Table', () => {
const TABLE = INSTANCE.table('table');

describe('close', () => {
it('should fail when invoking readRows with closed client', async () => {
it.skip('should fail when invoking readRows with closed client', async () => {
Copy link
Contributor

@kolea2 kolea2 Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add retries to this test instead? I would prefer not to skip it, unless it is consistently failing (in which case we should investigate an alternate solution there too).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added a change which will still allow the test to run and retry in the appropriate circumstances.

const instance = bigtable.instance(INSTANCE_NAME);
const table = instance.table('fake-table');
const [, operation] = await instance.create({
Expand All @@ -108,11 +108,14 @@ describe('Bigtable/Table', () => {
assert.strictEqual(err.message, 'The client has already been closed.');
}
});
/*
Add this block back in when the previous test is skipped
after(async () => {
const bigtableSecondClient = new Bigtable();
const instance = bigtableSecondClient.instance(INSTANCE_NAME);
await instance.delete({});
});
*/
});

describe('createReadStream', () => {
Expand Down
Loading