Skip to content

Commit

Permalink
test: Add conformance tests (#1349)
Browse files Browse the repository at this point in the history
* Add conformance tests

Add conformance tests that use the test proxy to ensure the client is running correctly.

* try this and see what it does

* Revert "try this and see what it does"

This reverts commit aa18af6.

* Make the yaml config run node and not java

If the yaml config sets up node then the node test proxy can be tested.

* Add echo to test

* Add conformance to main CI pipeline instead

* Add execution permissions

* typo correction

* Revert "typo correction"

This reverts commit 2bb0eed.

* Revert "Add execution permissions"

This reverts commit 80d5569.

* Revert "Add conformance to main CI pipeline instead"

This reverts commit 359d413.

* After reverts, rearrange files for best setup

Add execution permissions to the conformance shell file.

* Add logs to see what it does

* Try adding more logs

* Make sure it doesn’t get stuck

Add &

* Correct conformance paths test run path

The path for the known failures is wrong and needs to be corrected.

* Try without setting the proxy address

* Fix path to the known failures again

* Add a known failure so test will work

Errors out because skip has no argument

* Set the proxy address

The proxy address needs to be set to where the test proxy is listening

* Add known failures based on tests that fail

The known failures should be added to the file so that those tests can be skipped

* Put all the test names on one line

By putting all the test names on one line maybe they will all be picked up to be skipped rather than just one of them.

* Try using an ampersand to separate parameters

* Revert "Try using an ampersand to separate parameters"

This reverts commit cb9f89d.

* Try unit array syntax

Using the unix array syntax should make it easier to process the files.

* Revert "Try unit array syntax"

This reverts commit 1bb86d2.

* Try reordering the items in known failures

See if output mutes first test

* Try adding a comma

See if multiple arguments are accepted when a comma is added.

* Use correct delimiter syntax for known failures

This commit uses the right syntax for including all tests that need to be skipped.

* Add additional failures that were skipped before

Add tests to be skipped so that the conformance Github action passes.

* Add the last known failure

One more known failure needs to be included

* Remove output log location

The mentioned script is a leftover copy/paste error

* Remove unecessary logging from script

Logging used to debug should not be part of the script anymore.

* run the linter

Run the linter

* remove console logs

* Test on multiple versions of node

The conformance tests may catch more issues to do with streaming and such if more versions of node are covered.

* Eliminate logging for debugging

pwd and ls should not be left in the script

* Remove pushd and popd

These two commands are unnecessary as nothing is run after them.

* Remove known failures list of test

As required, remove the list of known failures

* Add a cleanup operation

The cleanup operation should happen no matter how the program exits.

* Empty-Commit
  • Loading branch information
danieljbruce authored Oct 12, 2023
1 parent 906ac79 commit 5cc0523
Show file tree
Hide file tree
Showing 2 changed files with 89 additions and 0 deletions.
44 changes: 44 additions & 0 deletions .github/workflows/conformance.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Github action job to test core java library features on
# downstream client libraries before they are released.
on:
push:
branches:
- main
pull_request:
name: conformance
jobs:
conformance:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 14, 16, 18, 20 ]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v3
with:
repository: googleapis/cloud-bigtable-clients-test
ref: main
path: cloud-bigtable-clients-test
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: actions/setup-go@v4
with:
go-version: '>=1.20.2'
- run: chmod +x .kokoro/conformance.sh
- run: npm install
- run: go version
- run: .kokoro/conformance.sh
45 changes: 45 additions & 0 deletions .kokoro/conformance.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5cc0523

Please sign in to comment.