Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BulkWriter flush logic #1778

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: BulkWriter flush logic #1778

wants to merge 3 commits into from

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Aug 2, 2024 •
edited
Loading

Should fix: #1772

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 2, 2024
@tom-andersen tom-andersen changed the title Fix race condition fix: BulkWriter flush logic Aug 3, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Aug 3, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen marked this pull request as ready for review August 3, 2024 00:08
@tom-andersen tom-andersen requested a review from a team as a code owner August 3, 2024 00:08
@tom-andersen tom-andersen added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2024
milaGGL
milaGGL approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Tom.

@thewildllama
Copy link

I've tested this a few times, and it still hangs occasionally. I'd have to add more logging to figure out where things went off the rails... :(

@thewildllama thewildllama mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firestore.BulkWriter.flush() has a race
4 participants
@tom-andersen @thewildllama @milaGGL @yoshi-kokoro