Add KnownLayout trait #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-1-known-layout
branch
from
b15e438
to
d406386
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-1-known-layout
branch
2 times, most recently
from
7de1eff
to
887a5ae
Compare
jswrenn
previously approved these changes
Sep 7, 2023
In its initial form, the `KnownLayout` trait encodes type layout information slightly more complex than can be gleaned from any arbitrary `T: ?Sized`. This allows it to support not just sized and slice types, but also "custom DSTs" (those with fixed-size fields followed by a trailing slice type). This is the first step to supporting various operations on arbitrary custom DSTs. Makes progress on #29
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-1-known-layout
branch
from
887a5ae
to
f7c1d7b
Compare
|
There's a bit of different logic to handle |
jswrenn
approved these changes
Sep 7, 2023
joshlf
deleted the
try-from-bytes-raw-argument-to-is-bit-valid-1-known-layout
branch
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its initial form, the
KnownLayouttrait encodes type layout information slightly more complex than can be gleaned from any arbitraryT: ?Sized. This allows it to support not just sized and slice types, but also "custom DSTs" (those with fixed-size fields followed by a trailing slice type). This is the first step to supporting various operations on arbitrary custom DSTs.Makes progress on #29