Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Publish cargo doc to GitHub Pages #1227

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented May 10, 2024

No description provided.

@joshlf
Copy link
Member Author

joshlf commented May 10, 2024

Tested manually by setting the job to run on the pull_request trigger, which resulted in: https://google.github.io/zerocopy/

I've now removed that trigger.

@joshlf joshlf enabled auto-merge May 10, 2024 02:23
@joshlf joshlf requested a review from jswrenn May 10, 2024 02:23
@jswrenn
Copy link
Collaborator

jswrenn commented May 10, 2024

Tested manually by setting the job to run on the pull_request trigger

Per-PR docs actually sounds awesome. Could you restore that functionality?

@joshlf
Copy link
Member Author

joshlf commented May 10, 2024

Not without more work - the impl for testing just clobbered the docs every time a new PR is uploaded. It'd be cool to have separate docs for each PR, but it'd take more engineering work. We should do it as a follow-up though.

@joshlf joshlf added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit e86e363 May 10, 2024
210 checks passed
@joshlf joshlf deleted the cargo-docs-github-pages branch May 10, 2024 14:30
@joshlf joshlf mentioned this pull request May 10, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants