Add RenderDoc integration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the RenderDoc API programatically start a capture. We need this because uVkCompute does not present any frames and frame-oriented tools do not know when to start on their own. The initial implementation supports linux only. The RenderDoc header is vendored under `/third_party`. RenderDoc capture is enabled with a new `--enable_renderdoc` flag. This is coarse-grained: we start a signle capture for all of the benchmarks, so you may want to combine it with a `--benchmark_filter` to profile only some configurations of interest. In the future we may want to make it more fine-grained, e.g., per registered benchmark, but I was not able to find a clean way to hook into the loop over the final benchmark list. Note that this transitively enables RGP (Radeon GPU Profiler) support, although without instruction timing.
|
The formatting failure is expected for the renderdoc header in third_party. Probably not worth fixing the lint script just for this. |
antiagainst
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the RenderDoc API programmatically start a capture. We need this because uVkCompute does not present any frames and frame-oriented tools do not know when to start on their own.
The initial implementation supports linux only. The RenderDoc header is vendored under
/third_party.RenderDoc capture is enabled with a new
--enable_renderdocflag. This is coarse-grained: we start a single capture for all of the benchmarks, so you may want to combine it with a--benchmark_filterto profile only some configurations of interest.In the future we may want to make it more fine-grained, e.g., per registered benchmark, but I was not able to find a clean way to hook into the loop over the final benchmark list.
Note that this transitively enables RGP (Radeon GPU Profiler) support, although without instruction timing.