Skip to content

Commit

Permalink
tracing_integration_test: Remove WaitForTraceWritersChanged
Browse files Browse the repository at this point in the history
It accesses internal implementation details. Let's use RunUntilIdle()
instead.

Change-Id: I84e09d299c1293489e2674e83bf90a771f19c203
  • Loading branch information
ddiproietto committed Oct 7, 2024
1 parent deee9b1 commit 3d3de5a
Showing 1 changed file with 1 addition and 30 deletions.
31 changes: 1 addition & 30 deletions src/tracing/test/tracing_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -200,35 +200,6 @@ class TracingIntegrationTest : public ::testing::Test {
return TracingService::ProducerSMBScrapingMode::kDefault;
}

void WaitForTraceWritersChanged(ProducerID producer_id) {
static int i = 0;
auto checkpoint_name = "writers_changed_" + std::to_string(producer_id) +
"_" + std::to_string(i++);
auto writers_changed = task_runner_->CreateCheckpoint(checkpoint_name);
auto writers = GetWriters(producer_id);
std::function<void()> task;
task = [&task, writers, writers_changed, producer_id, this]() {
if (writers != GetWriters(producer_id)) {
writers_changed();
return;
}
task_runner_->PostDelayedTask(task, 1);
};
task_runner_->PostDelayedTask(task, 1);
task_runner_->RunUntilCheckpoint(checkpoint_name);
}

const std::map<WriterID, BufferID>& GetWriters(ProducerID producer_id) {
return reinterpret_cast<TracingServiceImpl*>(svc_->service())
->GetProducer(producer_id)
->writers_;
}

ProducerID* last_producer_id() {
return &reinterpret_cast<TracingServiceImpl*>(svc_->service())
->last_producer_id_;
}

std::unique_ptr<base::TestTaskRunner> task_runner_;
std::unique_ptr<ServiceIPCHost> svc_;
std::unique_ptr<TracingService::ProducerEndpoint> producer_endpoint_;
Expand Down Expand Up @@ -515,7 +486,7 @@ TEST_F(TracingIntegrationTestWithSMBScrapingProducer, ScrapeOnFlush) {
ASSERT_TRUE(writer);

// Wait for the writer to be registered.
WaitForTraceWritersChanged(*last_producer_id());
task_runner_->RunUntilIdle();

// Write a few trace packets.
writer->NewTracePacket()->set_for_testing()->set_str("payload1");
Expand Down

0 comments on commit 3d3de5a

Please sign in to comment.