Skip to content

Commit

Permalink
fix deployment (#4406)
Browse files Browse the repository at this point in the history
  • Loading branch information
elalish authored Aug 1, 2023
1 parent 6e3af76 commit e88f462
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/deploy-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,14 @@ jobs:
# - name: Lint TypeScript sources
# run: npm run lint

- name: Bootstrap packages
run: npm run bootstrap

- name: Build packages
run: npm run build

- name: Generate fidelity artifacts
continue-on-error: true
uses: GabrielBB/[email protected]
with:
run: ./node_modules/.bin/lerna run --scope @google/model-viewer-render-fidelity-tools test --stream
run: npm run test --workspace=@google/model-viewer-render-fidelity-tools

- name: Stage documentation artifacts
run: ./packages/modelviewer.dev/scripts/ci-before-deploy.sh
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Then, perform the following steps to get set up for development:
git clone --depth=1 [email protected]:google/model-viewer.git
cd model-viewer
npm install
npm run bootstrap
```

Note: depth=1 keeps you from downloading our ~3Gb of history, which is dominated by all the versions of our golden render fidelity images.
Expand All @@ -40,7 +39,7 @@ The following global commands are available:

Command | Description
------------------------------ | -----------
`npm run bootstrap` | Bootstraps the project for development and cross-links sub-projects
`npm ci` | Install dependencies and cross-links sub-projects
`npm run build` | Runs the build step for all sub-projects
`npm run serve` | Runs a web server and opens a new browser tab pointed to the local copy of modelviewer.dev (don't forget to build!)
`npm run test` | Runs tests in all sub-projects that have them
Expand All @@ -61,7 +60,6 @@ To clone via HTTPS in WSL (there are known file permissions issues with SSH keys
git clone --depth=1 https://github.com/google/model-viewer.git
cd model-viewer
npm install
npm run bootstrap
```

To run tests in WSL, you need to bind `CHROME_BIN`:
Expand Down

0 comments on commit e88f462

Please sign in to comment.