Fix QuickLook (#1497)

* fix iosSrc * added iosSrc test
google · Sep 2, 2020 · 080e8db · 080e8db
1 parent 6912c16
commit 080e8db
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/model-viewer/src/features/ar.ts b/packages/model-viewer/src/features/ar.ts
@@ -325,15 +325,17 @@ configuration or device capabilities');
      * iOS can intent to their AR Quick Look.
      */
     [$openIOSARQuickLook]() {
-      const modelUrl = new URL(this.src!, self.location.toString());
+      const modelUrl = new URL(this.iosSrc!, self.location.toString());
       if (this.arScale === 'fixed') {
         modelUrl.hash = 'allowsContentScaling=0';
       }
       const anchor = this[$arAnchor];
       anchor.setAttribute('rel', 'ar');
-      anchor.appendChild(document.createElement('img'));
+      const img = document.createElement('img');
+      anchor.appendChild(img);
       anchor.setAttribute('href', modelUrl.toString());
       anchor.click();
+      anchor.removeChild(img);
     }
   }
 

diff --git a/packages/model-viewer/src/test/features/ar-spec.ts b/packages/model-viewer/src/test/features/ar-spec.ts
@@ -120,13 +120,15 @@ suite('ModelViewerElementBase with ARMixin', () => {
       suite('openQuickLook', () => {
         test('sets hash for fixed scale', () => {
           element.src = 'https://example.com/model.gltf';
+          element.iosSrc = 'https://example.com/model.usdz';
           element.arScale = 'fixed';
           (element as any)[$openIOSARQuickLook]();
 
           expect(intentUrls.length).to.be.equal(1);
 
           const url = new URL(intentUrls[0]);
 
+          expect(url.pathname).equal('/model.usdz');
           expect(url.hash).to.equal('#allowsContentScaling=0');
         });
       });